Issue 1151743002: Decrease Dart binary size by 1.7MB

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1151743002: Decrease Dart binary size by 1.7MB (Closed)

Created:
5 years, 7 months ago by Cutch

Modified:
5 years, 7 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Decrease Dart binary size by 1.7MB - Add flag to enable zlib compression of resources to create_resource.py - Enable flag for Observatory resources - Use 'dart:io' ZlibCodec to decompress resources when first loaded into service isolate. - Dart executable (debug, macos) goes from 15,460b to 13,752b R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/3442cad28615b4779f1ad73eb65cf406ab2e8fe2

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -10 lines)			Patch
M	runtime/bin/bin.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/vmservice/resources.dart	View	1 chunk	+13 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice_impl.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/tools/create_resources.py	View	8 chunks	+25 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

5 years, 7 months ago (2015-05-21 20:35:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3442cad28615b4779f1ad73eb65cf406ab2e8fe2 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages