Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1151723002: Don't get value in SingleMapIterator until it is requested. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't get value in SingleMapIterator until it is requested. So, later we can optimize couple places in AnalysisContextImpl. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/515d5db2cf6497d9172a8741b3b891dff357b31e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/utilities_collection.dart View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 7 months ago (2015-05-20 22:08:18 UTC) #1
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-20 22:10:34 UTC) #2
scheglov
5 years, 7 months ago (2015-05-20 22:11:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
515d5db2cf6497d9172a8741b3b891dff357b31e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698