Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Issue 1151573022: Fix for issue 192 in domokit/mojo (Closed)

Created:
5 years, 6 months ago by siva
Modified:
5 years, 6 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for issue 192 in domokit/mojo Serialize Mint objects as is and at the receving side convert them to Smi or Mints depending on the target architecture. BUG=192 from domokit/mojo R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/da0363172adaa266ef2d44cf87e09b61a185e79d

Patch Set 1 #

Patch Set 2 : self review comments #

Patch Set 3 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M runtime/vm/object.h View 1 3 chunks +9 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 2 1 chunk +10 lines, -4 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
siva
5 years, 6 months ago (2015-06-05 17:19:52 UTC) #2
srdjan
lgtm
5 years, 6 months ago (2015-06-05 17:25:09 UTC) #3
siva
5 years, 6 months ago (2015-06-05 21:45:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
da0363172adaa266ef2d44cf87e09b61a185e79d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698