Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 1151573011: Issue 23332. Don't compute overrides for static members. (Closed)

Created:
5 years, 6 months ago by scheglov
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_overrides.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_overrides_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 6 months ago (2015-06-01 17:27:59 UTC) #1
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-01 17:39:25 UTC) #2
scheglov
5 years, 6 months ago (2015-06-01 17:42:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f118546d067f9c230d25e0b908567459987d125f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698