Issue 1151443002: dart2js cps: Fix in how type variables are accessed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1151443002: dart2js cps: Fix in how type variables are accessed. (Closed)

Created:
5 years, 7 months ago by asgerf

Modified:
5 years, 7 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -17 lines)			Patch
M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/glue.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_runtime_types_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	4 chunks	+0 lines, -10 lines	0 comments	Download

Total messages: 4 (1 generated)

karlklose

LGTM, thanks. We could also have a version of the helper that takes the already ...

5 years, 7 months ago (2015-05-20 09:09:19 UTC) #3

asgerf

5 years, 7 months ago (2015-05-20 12:12:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
341b346f0e02958b4916a7a309c8d7bbe7ec91a1 (presubmit successful).