Issue 1151293004: Welcome charcode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1151293004: Welcome charcode (Closed)

Created:
5 years, 7 months ago by pquitslund

Modified:
5 years, 6 months ago

Reviewers:
Lasse Reichstein Nielsen, sethladd

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	DEPS	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Lasse Reichstein Nielsen

That looks ... exactly like all the other lines, so it's probably correct. LGTM.

5 years, 7 months ago (2015-05-23 00:02:01 UTC) #3

pquitslund

5 years, 6 months ago (2015-05-26 18:07:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3dc3b54b17e6f87d05de3461ddb13b8f8f31f433 (presubmit successful).