Issue 1151263004: Fix use-after-free deleting from linked list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1151263004: Fix use-after-free deleting from linked list. (Closed)

Created:
5 years, 6 months ago by rmacnak

Modified:
5 years, 6 months ago

Reviewers:
koda

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	runtime/vm/debugger.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

rmacnak

Committed patchset #1 (id:1) manually as 13592ca9b74501fc6aa1f92db925be8a1e5f0b4e (presubmit successful).

5 years, 6 months ago (2015-05-27 20:22:12 UTC) #1

koda

5 years, 6 months ago (2015-05-28 00:30:27 UTC) #2

Message was sent while issue was closed.

LGTM as a bug fix, but this code would really benefit from some abstraction,
like an iterator...