Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1151183003: Issue 23551. Fix for using type parameters of the enclosed classes in 'Create Missing Overrides' Qu… (Closed)

Created:
5 years, 6 months ago by scheglov
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 23551. Fix for using type parameters of the enclosed classes in 'Create Missing Overrides' Quick Fix. R=brianwilkerson@google.com BUG=https://code.google.com/p/dart/issues/detail?id=23551 Committed: https://github.com/dart-lang/sdk/commit/be9cd1c16564e3fec35437c184fa8e11e69227ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 2 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 6 months ago (2015-06-01 19:54:13 UTC) #1
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-01 20:20:54 UTC) #2
scheglov
5 years, 6 months ago (2015-06-01 21:19:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
be9cd1c16564e3fec35437c184fa8e11e69227ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698