Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1151133002: Allow spaces between the identifier and the translation when parsing ARB files (Closed)

Created:
5 years, 7 months ago by Alan Knight
Modified:
5 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/intl.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow spaces between the identifier and the translation when parsing ARB files BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/intl/commit/2f5e9fa81d805fd0aa3426768d8da315d37fb0ec

Patch Set 1 #

Patch Set 2 : Update changelog and pubspec #

Total comments: 2

Patch Set 3 : Make it 0.12.4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M CHANGELOG.md View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/icu_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/message_extraction/make_hardcoded_translation.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Alan Knight
5 years, 7 months ago (2015-05-21 20:16:14 UTC) #2
Bob Nystrom
lgtm https://codereview.chromium.org/1151133002/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1151133002/diff/20001/CHANGELOG.md#newcode3 CHANGELOG.md:3: where Google translation toolkit is now putting them. ...
5 years, 7 months ago (2015-05-21 20:27:09 UTC) #3
Alan Knight
https://codereview.chromium.org/1151133002/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1151133002/diff/20001/CHANGELOG.md#newcode3 CHANGELOG.md:3: where Google translation toolkit is now putting them. On ...
5 years, 7 months ago (2015-05-21 20:29:50 UTC) #4
Alan Knight
5 years, 7 months ago (2015-05-21 20:30:15 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
2f5e9fa81d805fd0aa3426768d8da315d37fb0ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698