Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1150863007: Remove many explicit references to AnalysisContextImpl and enable testing of the new task model (Closed)

Created:
5 years, 6 months ago by Brian Wilkerson
Modified:
5 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove many explicit references to AnalysisContextImpl and enable testing of the new task model R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/add5a6910d0bcca4b6b4743f9a18373398e14c69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -147 lines) Patch
M pkg/analysis_server/test/context_manager_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 3 chunks +3 lines, -11 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 51 chunks +53 lines, -63 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 2 chunks +14 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 24 chunks +112 lines, -54 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/test/task/task_dart_test.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 6 months ago (2015-06-05 21:45:07 UTC) #2
scheglov
LGTM
5 years, 6 months ago (2015-06-05 22:29:47 UTC) #3
Brian Wilkerson
5 years, 6 months ago (2015-06-06 15:30:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
add5a6910d0bcca4b6b4743f9a18373398e14c69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698