Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1150543004: Don't fail taskkill on chrome processes alive (Closed)

Created:
5 years, 6 months ago by ricow1
Modified:
5 years, 6 months ago
Reviewers:
eernst
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't fail taskkill on chrome processes alive It happens quite often that the browser controller fails to kill chrome on the package waterfall. R=eernst@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6d4aea874d8561c4392f88db453c960fc316e6bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/task_kill.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
5 years, 6 months ago (2015-06-04 10:35:10 UTC) #1
eernst
LGTM!
5 years, 6 months ago (2015-06-04 10:43:08 UTC) #2
ricow1
5 years, 6 months ago (2015-06-04 10:43:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6d4aea874d8561c4392f88db453c960fc316e6bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698