Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1150523003: dart2js cps: Fix default values for forwarding constructors. (Closed)

Created:
5 years, 7 months ago by asgerf
Modified:
5 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Fix default values for forwarding constructors. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/40fd8a0bcf8bdaef5a6bd4115c6a2b0ef4db77af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 7 months ago (2015-05-20 12:19:36 UTC) #2
karlklose
LGTM.
5 years, 7 months ago (2015-05-20 12:30:37 UTC) #3
asgerf
5 years, 7 months ago (2015-05-20 12:31:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
40fd8a0bcf8bdaef5a6bd4115c6a2b0ef4db77af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698