Issue 1150273003: Use Set instead of List for 'dependentResults'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1150273003: Use Set instead of List for 'dependentResults'. (Closed)

Created:
5 years, 7 months ago by scheglov

Modified:
5 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use Set instead of List for 'dependentResults'. With this change invalidation takes about 60 ms after a change in the cache.dart file. It is about 80 times after than now - 5000 ms. 60 ms still seems too high :-( R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1a324ac3e75777cadd5076538b566bd42cbd5b96

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	pkg/analyzer/lib/src/context/cache.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 7 months ago (2015-05-22 17:54:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1a324ac3e75777cadd5076538b566bd42cbd5b96 (presubmit successful).