Provide a logical view of VM-internal maps in Observatory.

Provide a logical view of VM-internal maps in Observatory.

BUG=http://dartbug.com/20551
BUG=http://dartbug.com/21185
R=koda@google.com

Committed: https://github.com/dart-lang/sdk/commit/eca0d72abe0b7b35f4772dcbedabd61d9a86ac05

[rmacnak, 2015-06-01 23:48:20]

rmacnak@google.com changed reviewers:
+ koda@google.com

[koda, 2015-06-02 16:42:37]

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:19380: Object& element = Object::Handle();
Thanks for fixing this.

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:19726: intptr_t len = OS::SNPrint(NULL, 0, format,
Length()) + 1;
Use Thread::Current()->zone()->PrintToString(...)

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object.h#new...
runtime/vm/object.h:7242: class Iterator : ValueObject {
Add comment to note how this differs from its Dart counterpart:
1. does not check for concurrent modifications.
2. crashes, rather than returns null, when the iterator is before beginning or
after end

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object.h#new...
runtime/vm/object.h:7246: , data_(Array::Handle(map.data()))
I think our code usually has these commas at the end of the lines.

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object.h#new...
runtime/vm/object.h:7249: , length_(Smi::Handle(map.used_data()).Value()) {}
Avoid handle creation: Smi::Value(map.used_data())

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object_test.cc
File runtime/vm/object_test.cc (right):

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object_test....
runtime/vm/object_test.cc:4747: EXPECT(!iterator.MoveNext());
Also test "Length" method.

[rmacnak, 2015-06-02 17:33:31]

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:19726: intptr_t len = OS::SNPrint(NULL, 0, format,
Length()) + 1;
On 2015/06/02 16:42:36, koda wrote:
> Use Thread::Current()->zone()->PrintToString(...)

Much nicer. Updated Array::ToCString as well.

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object.h#new...
runtime/vm/object.h:7242: class Iterator : ValueObject {
On 2015/06/02 16:42:37, koda wrote:
> Add comment to note how this differs from its Dart counterpart:
> 1. does not check for concurrent modifications.
> 2. crashes, rather than returns null, when the iterator is before beginning or
> after end

Done.

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object.h#new...
runtime/vm/object.h:7246: , data_(Array::Handle(map.data()))
On 2015/06/02 16:42:37, koda wrote:
> I think our code usually has these commas at the end of the lines.

Ah, yes. Before is Blink.

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object.h#new...
runtime/vm/object.h:7249: , length_(Smi::Handle(map.used_data()).Value()) {}
On 2015/06/02 16:42:37, koda wrote:
> Avoid handle creation: Smi::Value(map.used_data())

Done.

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object_test.cc
File runtime/vm/object_test.cc (right):

https://codereview.chromium.org/1150103005/diff/20001/runtime/vm/object_test....
runtime/vm/object_test.cc:4747: EXPECT(!iterator.MoveNext());
On 2015/06/02 16:42:37, koda wrote:
> Also test "Length" method.

Done.

[koda, 2015-06-02 17:34:47]

lgtm

[rmacnak, 2015-06-02 18:38:45]

Committed patchset #4 (id:60001) manually as
eca0d72abe0b7b35f4772dcbedabd61d9a86ac05 (presubmit successful).