Issue 1150033013: Clean up JSON parsing code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1150033013: Clean up JSON parsing code. (Closed)

Created:
5 years, 6 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 6 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Clean up JSON parsing code. Fixes some hard-to-find bugs and warnings. Improves the layout of all the constants. R=ajohnsen@google.com Committed: https://github.com/dart-lang/sdk/commit/de68aaa59584b16a8d100834ad428a202a2e8bc2

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -123 lines)			Patch
	M	runtime/lib/convert_patch.dart	View		15 chunks	+127 lines, -123 lines	0 comments	Download

Total messages: 4 (1 generated)

Lasse Reichstein Nielsen

5 years, 6 months ago (2015-06-04 12:55:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
de68aaa59584b16a8d100834ad428a202a2e8bc2 (presubmit successful).