Issue 11500004: Address comments about safely casting handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11500004: Address comments about safely casting handles. (Closed)

Created:
8 years ago by Florian Schneider

Modified:
7 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Address comments about safely casting handles. The debug version exactly follows the original code. Release mode avoid creating a temporary handle. Committed: https://code.google.com/p/dart/source/detail?r=17703

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	runtime/vm/object.cc	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

7 years, 11 months ago (2013-01-23 04:02:44 UTC) #3

Is still an outstanding review or has this patch outlived its usefulness?

-Ivan

Expand Messages | Collapse Messages