Reapply "Per-closure breakpoints; restructure breakpoint implementation to keep a list of condition…

Reapply "Per-closure breakpoints; restructure breakpoint implementation to keep a list of conditions."

Fix copying breakpoints over to a new location when a latent location is resolved.

Fix bad assumption that BreakpointLocationAtLine always returns non-null result.

Committed: https://github.com/dart-lang/sdk/commit/74dfae69e303b12d5313b4ac32b4535496735a79

[rmacnak, 2015-05-22 17:54:41]

rmacnak@google.com changed reviewers:
+ iposva@google.com

[rmacnak, 2015-05-22 17:54:42]

@@ -1939,8 +1939,11 @@ Breakpoint* Debugger::SetBreakpointAtActivation(
 
 Breakpoint* Debugger::SetBreakpointAtLine(const String& script_url,
                                           intptr_t line_number) {
-  BreakpointLocation* bpt = BreakpointLocationAtLine(script_url, line_number);
-  return bpt->AddRepeated(this);
+  BreakpointLocation* loc = BreakpointLocationAtLine(script_url, line_number);
+  if (loc != NULL) {
+    return loc->AddRepeated(this);
+  }
+  return NULL;
 }
 
 
@@ -2695,9 +2698,9 @@ void Debugger::NotifyDoneLoading() {
             RegisterBreakpointLocation(unresolved_loc);
 
             // Move breakpoints over.
-            Breakpoint* bpt = existing_loc->breakpoints();
+            Breakpoint* bpt = matched_loc->breakpoints();
             unresolved_loc->set_breakpoints(bpt);
-            existing_loc->set_breakpoints(NULL);
+            matched_loc->set_breakpoints(NULL);
             while (bpt != NULL) {
               bpt->set_bpt_location(unresolved_loc);
               if (FLAG_verbose_debug) {

[rmacnak, 2015-05-27 16:59:38]

Committed patchset #2 (id:20001) manually as
74dfae69e303b12d5313b4ac32b4535496735a79 (presubmit successful).

[Ivan Posva, 2015-05-27 20:24:47]

The new changes LGTM.

-Ivan