Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1149943009: Shrink some fields and add some bounds checks. (Closed)

Created:
5 years, 6 months ago by rmacnak
Modified:
5 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 3

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : #

Total comments: 6

Patch Set 7 : #

Patch Set 8 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -34 lines) Patch
M runtime/platform/globals.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 6 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 3 chunks +23 lines, -0 lines 2 comments Download
M runtime/vm/raw_object.h View 1 2 3 4 5 6 7 6 chunks +10 lines, -9 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 2 3 4 5 6 7 11 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
rmacnak
https://codereview.chromium.org/1149943009/diff/40001/runtime/vm/raw_object.h File runtime/vm/raw_object.h (right): https://codereview.chromium.org/1149943009/diff/40001/runtime/vm/raw_object.h#newcode620 runtime/vm/raw_object.h:620: uint16_t id_; // Class Id, also index in the ...
5 years, 6 months ago (2015-06-02 21:04:11 UTC) #2
rmacnak
Added cid_t.
5 years, 6 months ago (2015-06-03 21:57:46 UTC) #3
rmacnak
Also marked regexp_cid_ in RawFunction as cid_t. PTAL.
5 years, 6 months ago (2015-06-08 22:50:47 UTC) #4
siva
https://codereview.chromium.org/1149943009/diff/80001/runtime/platform/globals.h File runtime/platform/globals.h (right): https://codereview.chromium.org/1149943009/diff/80001/runtime/platform/globals.h#newcode345 runtime/platform/globals.h:345: typedef uint16_t cid_t; Should we call it classid_t to ...
5 years, 6 months ago (2015-06-08 23:09:22 UTC) #5
rmacnak
https://codereview.chromium.org/1149943009/diff/80001/runtime/platform/globals.h File runtime/platform/globals.h (right): https://codereview.chromium.org/1149943009/diff/80001/runtime/platform/globals.h#newcode345 runtime/platform/globals.h:345: typedef uint16_t cid_t; On 2015/06/08 23:09:21, siva wrote: > ...
5 years, 6 months ago (2015-06-09 00:02:51 UTC) #6
siva
lgtm https://codereview.chromium.org/1149943009/diff/140001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1149943009/diff/140001/runtime/vm/object.cc#newcode8702 runtime/vm/object.cc:8702: String& url = String::Handle(lib.url()); const String& url
5 years, 6 months ago (2015-06-09 01:29:02 UTC) #7
rmacnak
https://codereview.chromium.org/1149943009/diff/140001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1149943009/diff/140001/runtime/vm/object.cc#newcode8702 runtime/vm/object.cc:8702: String& url = String::Handle(lib.url()); On 2015/06/09 01:29:02, siva wrote: ...
5 years, 6 months ago (2015-06-09 17:47:11 UTC) #8
rmacnak
5 years, 6 months ago (2015-06-09 17:47:30 UTC) #9
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) manually as
a16abcdf5af811b76c71bc084088c6b3c528c0ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698