Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1149933007: Remove serializer whitelisting for 'dart:collection' (Closed)

Created:
5 years, 6 months ago by koda
Modified:
5 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove serializer whitelisting for 'dart:collection' Since LinkedHashMap is now VM-internal, this exception is no longer needed. BUG=22982 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/092d27cf347b32ecbbdaa9c4ab3b35ab8d718cf8

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M runtime/vm/raw_object_snapshot.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +1 line, -2 lines 2 comments Download

Messages

Total messages: 4 (1 generated)
koda
https://codereview.chromium.org/1149933007/diff/1/runtime/vm/snapshot.cc File runtime/vm/snapshot.cc (right): https://codereview.chromium.org/1149933007/diff/1/runtime/vm/snapshot.cc#newcode2165 runtime/vm/snapshot.cc:2165: return library == object_store()->typed_data_library(); I'm not sure why this ...
5 years, 6 months ago (2015-05-29 15:40:22 UTC) #2
siva
lgtm https://codereview.chromium.org/1149933007/diff/1/runtime/vm/snapshot.cc File runtime/vm/snapshot.cc (right): https://codereview.chromium.org/1149933007/diff/1/runtime/vm/snapshot.cc#newcode2165 runtime/vm/snapshot.cc:2165: return library == object_store()->typed_data_library(); On 2015/05/29 15:40:21, koda ...
5 years, 6 months ago (2015-05-29 15:46:58 UTC) #3
koda
5 years, 6 months ago (2015-05-29 16:18:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
092d27cf347b32ecbbdaa9c4ab3b35ab8d718cf8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698