Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1149923005: Narrow suppression of animation tests to MacOS (Closed)

Created:
5 years, 7 months ago by Alan Knight
Modified:
5 years, 7 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Clean up sections #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tests/html/html.status View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Alan Knight
5 years, 7 months ago (2015-05-26 20:41:48 UTC) #2
Bill Hesse
lgtm https://codereview.chromium.org/1149923005/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/1149923005/diff/1/tests/html/html.status#newcode141 tests/html/html.status:141: transition_event_test/functional: Skip # Times out. Issue 22167 Can ...
5 years, 7 months ago (2015-05-27 08:00:33 UTC) #3
Alan Knight
https://codereview.chromium.org/1149923005/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/1149923005/diff/1/tests/html/html.status#newcode141 tests/html/html.status:141: transition_event_test/functional: Skip # Times out. Issue 22167 On 2015/05/27 ...
5 years, 7 months ago (2015-05-27 17:35:14 UTC) #4
Alan Knight
5 years, 7 months ago (2015-05-27 17:35:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
048079dc206f304a1e6721bc52d4cbc198359775 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698