Issue 11498013: Follow the redirect rules from RFC 2616

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11498013: Follow the redirect rules from RFC 2616 (Closed)

Created:
8 years ago by Søren Gjesse

Modified:
8 years ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Follow the redirect rules from RFC 2616 R=ajohnsen@google.com BUG=dart:7150 Committed: https://code.google.com/p/dart/source/detail?r=15960

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -5 lines)			Patch
	M	sdk/lib/io/http_impl.dart	View		2 chunks	+16 lines, -5 lines	0 comments	Download
	M	tests/standalone/io/http_redirect_test.dart	View		3 chunks	+99 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM, nice with the change of POST to GET. Should the POST drop the body ...

8 years ago (2012-12-10 15:29:09 UTC) #2

Søren Gjesse

8 years ago (2012-12-11 09:45:14 UTC) #3

On 2012/12/10 15:29:09, Anders Johnsen wrote:
> LGTM, nice with the change of POST to GET. Should the POST drop the body in
such
> case?

Body data is always dropped when redirecting. Updated the comments in http.dart
to say that. Also added comments on the status codes for which automatic
redirect can happen.

Expand Messages | Collapse Messages