Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 1149723004: Fix context creation in tests (Closed)

Created:
5 years, 7 months ago by Brian Wilkerson
Modified:
5 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Back-out unintended change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M pkg/analysis_server/test/mock_sdk.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/mock_sdk.dart View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 7 months ago (2015-05-22 21:19:04 UTC) #2
scheglov
LGTM
5 years, 7 months ago (2015-05-22 21:19:55 UTC) #3
Brian Wilkerson
5 years, 7 months ago (2015-05-22 21:25:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ad2b8a43c88dc41384a195169ad0cf4d1b81478e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698