Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1149473002: Check for null in 'Create Class' Quick Fix. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check for null in 'Create Class' Quick Fix. I don't know how to reproduce it. How is it possible to have a type name outside a CompilationUnitMember? R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8851388c439a474118acd6edb38bd139764b55b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -28 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +32 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 7 months ago (2015-05-19 16:26:16 UTC) #1
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-19 16:34:29 UTC) #2
scheglov
5 years, 7 months ago (2015-05-19 16:35:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8851388c439a474118acd6edb38bd139764b55b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698