Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 1149423009: cps_ir: Clean up BuilderTask. (Closed)

Created:
5 years, 6 months ago by karlklose
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -93 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 2 chunks +0 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +39 lines, -67 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 2 chunks +2 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_source_information_test.dart View 3 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
5 years, 6 months ago (2015-06-03 11:17:34 UTC) #1
Kevin Millikin (Google)
lgtm
5 years, 6 months ago (2015-06-03 13:30:27 UTC) #2
karlklose
5 years, 6 months ago (2015-06-04 07:07:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0e1673ead0e45faf92b63c86e05e4aaaf1fc7784 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698