Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1149403005: Prevent excessive deoptimization when optimistically assuming Smi in typed data stores. (Closed)

Created:
5 years, 6 months ago by srdjan
Modified:
5 years, 6 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Prevent excessive deoptimization when optimistically assuming Smi in typed data stores. Moved ICData ahead of class Function, since class Function needs type ICData::DeoptReasonID. BUG= R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/b611952eaddbaceee2955c9f025e7c3f54de7cf9

Patch Set 1 #

Patch Set 2 : ws #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1731 lines, -1708 lines) Patch
M runtime/vm/deferred_objects.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/object.h View 1 chunk +1708 lines, -1705 lines 2 comments Download
M runtime/vm/object.cc View 1 chunk +14 lines, -1 line 0 comments Download
M runtime/vm/weak_code.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
srdjan
5 years, 6 months ago (2015-05-29 22:03:11 UTC) #2
Florian Schneider
https://codereview.chromium.org/1149403005/diff/20001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/1149403005/diff/20001/runtime/vm/object.h#newcode1709 runtime/vm/object.h:1709: // Object holding information about an IC: test classes ...
5 years, 6 months ago (2015-06-01 07:50:17 UTC) #3
srdjan
https://codereview.chromium.org/1149403005/diff/20001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/1149403005/diff/20001/runtime/vm/object.h#newcode1709 runtime/vm/object.h:1709: // Object holding information about an IC: test classes ...
5 years, 6 months ago (2015-06-01 15:23:40 UTC) #4
Florian Schneider
lgtm
5 years, 6 months ago (2015-06-01 15:51:57 UTC) #5
srdjan
5 years, 6 months ago (2015-06-01 18:44:01 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b611952eaddbaceee2955c9f025e7c3f54de7cf9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698