Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1700)

Issue 1149373006: Add getVersion and setLibraryDebuggable RPCs to the service protocol. (Closed)

Created:
5 years, 6 months ago by turnidge
Modified:
5 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add getVersion and setLibraryDebuggable RPCs to the service protocol. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/67adc6102db3bdf9d26ab91de95eb2333d21f371

Patch Set 1 #

Total comments: 2

Patch Set 2 : post code review #

Patch Set 3 : post merge #

Patch Set 4 : when all is said and done #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -31 lines) Patch
M runtime/observatory/lib/service_common.dart View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/get_object_rpc_test.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + runtime/observatory/tests/service/get_version_rpc_test.dart View 1 chunk +10 lines, -9 lines 0 comments Download
A runtime/observatory/tests/service/set_library_debuggable_rpc_test.dart View 1 chunk +62 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 12 chunks +61 lines, -18 lines 0 comments Download
M runtime/vm/service/service.md View 1 2 5 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
5 years, 6 months ago (2015-05-28 19:49:03 UTC) #2
Cutch
LGTM with a suggestion https://codereview.chromium.org/1149373006/diff/1/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/1149373006/diff/1/runtime/vm/service.cc#newcode1887 runtime/vm/service.cc:1887: JSONObject jsobj(js); Might be worth ...
5 years, 6 months ago (2015-05-28 19:59:19 UTC) #3
turnidge
https://codereview.chromium.org/1149373006/diff/1/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/1149373006/diff/1/runtime/vm/service.cc#newcode1887 runtime/vm/service.cc:1887: JSONObject jsobj(js); On 2015/05/28 19:59:19, Cutch wrote: > Might ...
5 years, 6 months ago (2015-05-28 20:06:58 UTC) #4
turnidge
5 years, 6 months ago (2015-05-28 20:34:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
67adc6102db3bdf9d26ab91de95eb2333d21f371 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698