Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1149303006: Let Backend determine support for deferred loading. (Closed)

Created:
5 years, 6 months ago by Johnni Winther
Modified:
5 years, 6 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Let Backend determine support for deferred loading. BUG= R=ajohnsen@google.com Committed: https://github.com/dart-lang/sdk/commit/c03bbb79f9cbc3486d054dc832d8ed67679ba491

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +3 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 6 months ago (2015-06-08 07:57:13 UTC) #2
Anders Johnsen
LGTM! https://codereview.chromium.org/1149303006/diff/1/pkg/compiler/lib/src/warnings.dart File pkg/compiler/lib/src/warnings.dart (right): https://codereview.chromium.org/1149303006/diff/1/pkg/compiler/lib/src/warnings.dart#newcode1367 pkg/compiler/lib/src/warnings.dart:1367: "Deferred loading is not supported by the dart ...
5 years, 6 months ago (2015-06-08 08:06:29 UTC) #3
Johnni Winther
Committed patchset #1 (id:1) manually as c03bbb79f9cbc3486d054dc832d8ed67679ba491 (presubmit successful).
5 years, 6 months ago (2015-06-08 08:11:17 UTC) #4
Johnni Winther
5 years, 6 months ago (2015-06-08 08:42:36 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1149303006/diff/1/pkg/compiler/lib/src/warnin...
File pkg/compiler/lib/src/warnings.dart (right):

https://codereview.chromium.org/1149303006/diff/1/pkg/compiler/lib/src/warnin...
pkg/compiler/lib/src/warnings.dart:1367: "Deferred loading is not supported by
the dart backend yet. "
On 2015/06/08 08:06:29, Anders Johnsen wrote:
> ?

Needed between '... yet.' and 'The output ...'.

Powered by Google App Engine
This is Rietveld 408576698