Issue 11492007: Add test case for issue 7191.

Issue 11492007: Add test case for issue 7191. (Closed)

Created:
8 years ago by Mads Ager (google)

Modified:
8 years ago

Reviewers:
kusterman, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add test case for issue 7191. R=ahe@google.com,kusterman@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15908

Patch Set 2 : Add comments that went missing. #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -0 lines)			Patch
	A	tests/standalone/io/regress_7191_script.dart	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download
	A	tests/standalone/io/regress_7191_test.dart	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/11492007/diff/1/tests/standalone/io/regress_7191_test.dart File tests/standalone/io/regress_7191_test.dart (right): https://codereview.chromium.org/11492007/diff/1/tests/standalone/io/regress_7191_test.dart#newcode4 tests/standalone/io/regress_7191_test.dart:4: Add a comment to explain the purpose and ...

8 years ago (2012-12-10 13:04:10 UTC) #2

Mads Ager (google)

8 years ago (2012-12-10 13:22:48 UTC) #3

https://codereview.chromium.org/11492007/diff/1/tests/standalone/io/regress_7...
File tests/standalone/io/regress_7191_test.dart (right):

https://codereview.chromium.org/11492007/diff/1/tests/standalone/io/regress_7...
tests/standalone/io/regress_7191_test.dart:4: 
On 2012/12/10 13:04:10, ahe wrote:
> Add a comment to explain the purpose and how this test works.

Yes, sorry, I did in patch set 2. My comments never got committed. :(

https://codereview.chromium.org/11492007/diff/1/tests/standalone/io/regress_7...
tests/standalone/io/regress_7191_test.dart:6: import 'dart:isolate';
On 2012/12/10 13:04:10, ahe wrote:
> Unnecessary import?

Yes. Removed in patch set 2 which I did not commit before uploading. :(

https://codereview.chromium.org/11492007/diff/1/tests/standalone/io/regress_7...
tests/standalone/io/regress_7191_test.dart:15: process.stdout.onData =
process.stdout.read;
On 2012/12/10 13:04:10, ahe wrote:
> This is not immediately obvious to me.  What does it do?

It drains stdout and stderr of the sub-process. It might be easier to read if
you have:

process.stdout.onData = () => process.stdout.read();

On each data event, just read the data and ignore it.

Expand Messages | Collapse Messages