Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1149083007: Fix for DeclarationResolver. (Closed)

Created:
5 years, 6 months ago by scheglov
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for DeclarationResolver. It's not the main problem we observe during pkg/analysis_server/test/operation/operation_test, but I still saw it. The actual fix is removing "unary-". The other change is just for performance. It is much cheaper to compare int(s) than to compute (for methods) 'displayName'. Maybe we should go as far as removing the name check altogether and use just element kind. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a9632f3babf0b623264342ea9edd2c870af21a16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 6 months ago (2015-06-04 01:38:58 UTC) #1
Brian Wilkerson
LGTM, but I don't understand why we didn't run into this problem until moving to ...
5 years, 6 months ago (2015-06-04 02:51:57 UTC) #2
scheglov
On 2015/06/04 02:51:57, Brian Wilkerson wrote: > LGTM, but I don't understand why we didn't ...
5 years, 6 months ago (2015-06-04 02:59:55 UTC) #3
scheglov
5 years, 6 months ago (2015-06-04 17:41:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a9632f3babf0b623264342ea9edd2c870af21a16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698