Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1148723005: Make expect* throw useful errors outside tests. (Closed)

Created:
5 years, 6 months ago by nweiz
Modified:
5 years, 6 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make expect* throw useful errors outside tests. Closes #132 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/cebcb3dc51529971dc3b4c69fc5527fb8fad5e90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/frontend/expect.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/frontend/expect_async.dart View 2 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 6 months ago (2015-06-01 20:52:33 UTC) #1
kevmoo
lgtm
5 years, 6 months ago (2015-06-01 22:11:20 UTC) #2
nweiz
5 years, 6 months ago (2015-06-01 22:30:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cebcb3dc51529971dc3b4c69fc5527fb8fad5e90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698