Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 11485012: Clean up command help. (Closed)

Created:
8 years ago by Bob Nystrom
Modified:
8 years ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clean up command help. It was missing a newline before which made it look busted: some command helpUsage: pub foo Committed: https://code.google.com/p/dart/source/detail?r=15944

Patch Set 1 #

Total comments: 2

Patch Set 2 : Test command help with options. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -37 lines) Patch
M utils/pub/command_help.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/command_install.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/command_lish.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/command_update.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/command_version.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/pub.dart View 1 2 chunks +10 lines, -12 lines 0 comments Download
M utils/tests/pub/pub_test.dart View 1 2 chunks +43 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
8 years ago (2012-12-11 01:18:45 UTC) #1
nweiz
lgtm https://codereview.chromium.org/11485012/diff/1/utils/tests/pub/pub_test.dart File utils/tests/pub/pub_test.dart (right): https://codereview.chromium.org/11485012/diff/1/utils/tests/pub/pub_test.dart#newcode90 utils/tests/pub/pub_test.dart:90: Usage: pub install We should also test this ...
8 years ago (2012-12-11 01:28:38 UTC) #2
Bob Nystrom
8 years ago (2012-12-11 02:15:07 UTC) #3
Thanks!

https://codereview.chromium.org/11485012/diff/1/utils/tests/pub/pub_test.dart
File utils/tests/pub/pub_test.dart (right):

https://codereview.chromium.org/11485012/diff/1/utils/tests/pub/pub_test.dart...
utils/tests/pub/pub_test.dart:90: Usage: pub install
On 2012/12/11 01:28:38, nweiz wrote:
> We should also test this for a command with options.

Done.

Powered by Google App Engine
This is Rietveld 408576698