Issue 1148443005: Use an auto-generated pub snapshot for tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1148443005: Use an auto-generated pub snapshot for tests. (Closed)

Created:
5 years, 7 months ago by nweiz

Modified:
5 years, 7 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub_test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Use an auto-generated pub snapshot for tests. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/a620958d0b861636be2a0784b38364d34e790101

Patch Set 2 : Code review changes #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -9 lines)			Patch
M	lib/src/git.dart	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	lib/src/io.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_pub.dart	View	1	4 chunks	+61 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

lgtm https://codereview.chromium.org/1148443005/diff/1/test/test_pub.dart File test/test_pub.dart (right): https://codereview.chromium.org/1148443005/diff/1/test/test_pub.dart#newcode566 test/test_pub.dart:566: '--snapshot=${p.join(pubRoot, '.pub', 'pub.test.snapshot')}', $snapshotPath

5 years, 7 months ago (2015-05-20 21:08:41 UTC) #2

nweiz

https://codereview.chromium.org/1148443005/diff/1/test/test_pub.dart File test/test_pub.dart (right): https://codereview.chromium.org/1148443005/diff/1/test/test_pub.dart#newcode566 test/test_pub.dart:566: '--snapshot=${p.join(pubRoot, '.pub', 'pub.test.snapshot')}', On 2015/05/20 21:08:41, Bob Nystrom wrote: ...

5 years, 7 months ago (2015-05-20 21:16:19 UTC) #4

nweiz

5 years, 7 months ago (2015-05-20 21:16:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
a620958d0b861636be2a0784b38364d34e790101 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1148443005: Use an auto-generated pub snapshot for tests. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Messages