Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1148413004: Fill CacheEntry.modificationTime for implicit sources. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fill CacheEntry.modificationTime for implicit sources. So that _validateCacheConsistency() will do nothing for them. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/87fe6b2408e52461932623f7b1947b20a91a9eb8

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 7 months ago (2015-05-22 18:50:13 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1148413004/diff/1/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/1148413004/diff/1/pkg/analyzer/lib/src/context/context.dart#newcode683 pkg/analyzer/lib/src/context/context.dart:683: entry.modificationTime = getModificationStamp(target); Unless we explicitly want to ...
5 years, 7 months ago (2015-05-22 18:58:52 UTC) #2
scheglov
https://codereview.chromium.org/1148413004/diff/1/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/1148413004/diff/1/pkg/analyzer/lib/src/context/context.dart#newcode683 pkg/analyzer/lib/src/context/context.dart:683: entry.modificationTime = getModificationStamp(target); On 2015/05/22 18:58:52, Brian Wilkerson wrote: ...
5 years, 7 months ago (2015-05-22 19:17:30 UTC) #3
scheglov
5 years, 7 months ago (2015-05-22 19:18:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
87fe6b2408e52461932623f7b1947b20a91a9eb8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698