Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1148153002: Reuse CompilationUnitElement in BuildCompilationUnitElementTask. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reuse CompilationUnitElement in BuildCompilationUnitElementTask. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b6fbad3348ef28a96860b06a7a8ff828dcf946d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -6 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +17 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/context/abstract_context.dart View 3 chunks +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 3 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 7 months ago (2015-05-20 17:41:04 UTC) #1
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-20 18:03:00 UTC) #2
scheglov
5 years, 7 months ago (2015-05-20 18:12:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b6fbad3348ef28a96860b06a7a8ff828dcf946d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698