Issue 1148093005: Fix a bug when narrowing the result type of a field get.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1148093005: Fix a bug when narrowing the result type of a field get. (Closed)

Created:
5 years, 7 months ago by karlklose

Modified:
5 years, 7 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix a bug when narrowing the result type of a field get. This fixes an assertion failure that occured after the optimizations in 0ef007d00bd8fd61f80c0ce032289474e88fa278, when we tried to rewrite a field get for a .length expression, where we already had a more specific type and used that in a truncating divide. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/c0a14a9af21de0378e5ff79bbb4a296c8f86a68b

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	pkg/compiler/lib/src/ssa/optimize.dart	View		1 chunk	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

5 years, 7 months ago (2015-05-27 06:33:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c0a14a9af21de0378e5ff79bbb4a296c8f86a68b (presubmit successful).

Expand Messages | Collapse Messages