Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1147913004: Emit json-rpc version in service protocol responses. (Closed)

Created:
5 years, 7 months ago by turnidge
Modified:
5 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Emit json-rpc version in service protocol responses. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/38ef2ac7e193776356567ded02d7e1d5d5a62bf9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M runtime/vm/json_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/service_test.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 7 months ago (2015-05-27 17:36:25 UTC) #2
rmacnak
lgtm
5 years, 7 months ago (2015-05-27 17:39:33 UTC) #3
turnidge
5 years, 7 months ago (2015-05-27 17:43:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
38ef2ac7e193776356567ded02d7e1d5d5a62bf9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698