Issue 11476021: Reapply "Do not call ResolveCompileInstanceFunction from the lookup stub."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11476021: Reapply "Do not call ResolveCompileInstanceFunction from the lookup stub." (Closed)

Created:
8 years ago by Kevin Millikin (Google)

Modified:
8 years ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Do not call ResolveCompileInstanceFunction from the lookup stub." With a fix for a crash bug on x64. The near jump encoding could fail on some platforms due to platform-specific code. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15845

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -154 lines)			Patch
M	runtime/vm/code_generator.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	2 chunks	+30 lines, -65 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	2 chunks	+30 lines, -65 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

https://codereview.chromium.org/11476021/diff/1/runtime/vm/stub_code_x64.cc File runtime/vm/stub_code_x64.cc (right): https://codereview.chromium.org/11476021/diff/1/runtime/vm/stub_code_x64.cc#newcode338 runtime/vm/stub_code_x64.cc:338: __ j(EQUAL, &function_not_found); This is not a near jump ...

8 years ago (2012-12-07 12:55:18 UTC) #1

LGTM.

Expand Messages | Collapse Messages