Issue 11475026: By default use current code page on Windows for decoding string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11475026: By default use current code page on Windows for decoding string (Closed)

Created:
8 years ago by Mads Ager (google)

Modified:
8 years ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

By default use current code page on Windows for decoding string data from processes. R=sgjesse@google.com BUG=dartbug.com/7180 Committed: https://code.google.com/p/dart/source/detail?r=15844

Patch Set 3 : Address comment #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -5 lines)			Patch
M	runtime/bin/io_natives.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/bin/process.cc	View	1	2 chunks	+34 lines, -0 lines	0 comments	Download
M	runtime/bin/process_patch.dart	View	1	2 chunks	+14 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/io_patch.dart	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	sdk/lib/io/input_stream.dart	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sdk/lib/io/process.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/io/string_stream.dart	View		4 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/11475026/diff/1008/sdk/lib/io/process.dart File sdk/lib/io/process.dart (right): https://codereview.chromium.org/11475026/diff/1008/sdk/lib/io/process.dart#newcode151 sdk/lib/io/process.dart:151: * The default stdoutEncoding is SYSTEM. Are we ...

8 years ago (2012-12-07 12:00:11 UTC) #2

Mads Ager (google)

8 years ago (2012-12-07 12:50:02 UTC) #3

https://codereview.chromium.org/11475026/diff/1008/sdk/lib/io/process.dart
File sdk/lib/io/process.dart (right):

https://codereview.chromium.org/11475026/diff/1008/sdk/lib/io/process.dart#ne...
sdk/lib/io/process.dart:151: * The default stdoutEncoding is SYSTEM.
On 2012/12/07 12:00:11, Søren Gjesse wrote:
> Are we going to try to explain what that means?

Yes. I used to have a comment in Encoding on the constant. I'll add that again.

Expand Messages | Collapse Messages

Issue 11475026: By default use current code page on Windows for decoding string (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix typos #

Patch Set 3 : Address comment #

Messages