Issue 11475020: Revert "Add @deprecated and @override to core."

Issue 11475020: Revert "Add @deprecated and @override to core." (Closed)

Created:
8 years ago by Lasse Reichstein Nielsen

Modified:
8 years ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Add @deprecated and @override to core." Revert "Adding deprecated flag to deprecated members." The "deprecated" and "override" features are still not accepted as language features, and shouldn't be in the SDK until they are. Committed: https://code.google.com/p/dart/source/detail?r=15839

Patch Set 1 #

Total comments: 6

Patch Set 2 : Just remove the @deprecated, not the other changes to html. #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -43 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/theme/preferences/DartSample.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/core/core.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/core/corelib_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	sdk/lib/core/metadata.dart	View	1 chunk	+0 lines, -29 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_Element.darttemplate	View	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Sorry about me adding this to the SDK prematurely.

8 years ago (2012-12-07 09:07:30 UTC) #2

ahe

There are a few surprising changes, but the @deprecated stuff LGTM https://codereview.chromium.org/11475020/diff/1/sdk/lib/html/html_common/html_common.dart File sdk/lib/html/html_common/html_common.dart (left): ...

8 years ago (2012-12-07 09:14:59 UTC) #3

Lasse Reichstein Nielsen

The questionable changes have been omitted. https://codereview.chromium.org/11475020/diff/1/sdk/lib/html/html_common/html_common.dart File sdk/lib/html/html_common/html_common.dart (left): https://codereview.chromium.org/11475020/diff/1/sdk/lib/html/html_common/html_common.dart#oldcode7 sdk/lib/html/html_common/html_common.dart:7: import 'dart:collection'; My ...

8 years ago (2012-12-07 09:27:07 UTC) #4

blois

8 years ago (2012-12-07 17:59:24 UTC) #6

Message was sent while issue was closed.

On 2012/12/07 09:27:07, Lasse Reichstein Nielsen wrote:
> The questionable changes have been omitted.
> 
>
https://codereview.chromium.org/11475020/diff/1/sdk/lib/html/html_common/html...
> File sdk/lib/html/html_common/html_common.dart (left):
> 
>
https://codereview.chromium.org/11475020/diff/1/sdk/lib/html/html_common/html...
> sdk/lib/html/html_common/html_common.dart:7: import 'dart:collection';
> My fault. I reverted the CL adding @deprecated to the html library based on
its
> description, and didn't notice that it did more than just add @deprecated.
I'll
> just remove the @deprecated instead.

Apologies for the second inclusion, lgtm.

Expand Messages | Collapse Messages