Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1147473002: Testing for appendHtml and insertAdjacentHtml should be consistently sanitized (Closed)

Created:
5 years, 7 months ago by Alan Knight
Modified:
5 years, 7 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Testing for appendHtml and insertAdjacentHtml should be consistently sanitized BUG= Committed: https://code.google.com/p/dart/source/detail?r=45807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -46 lines) Patch
M CHANGELOG.md View 1 chunk +8 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +12 lines, -10 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +8 lines, -4 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 8 chunks +165 lines, -14 lines 0 comments Download
M tests/co19/co19-dartium.status View 2 chunks +128 lines, -2 lines 0 comments Download
M tests/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +8 lines, -8 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Alan Knight
Putting it up for testing, will immediately revert.
5 years, 7 months ago (2015-05-15 01:08:59 UTC) #2
Alan Knight
5 years, 7 months ago (2015-05-15 01:10:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45807 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698