Issue 11474047: Validate that an uploaded package has a LICENSE file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11474047: Validate that an uploaded package has a LICENSE file. (Closed)

Created:
8 years ago by nweiz

Modified:
8 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Validate that an uploaded package has a LICENSE file. BUG=7045 Committed: https://code.google.com/p/dart/source/detail?r=15879

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -2 lines)			Patch
M	utils/pub/validator.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	utils/pub/validator/license.dart	View	1 chunk	+28 lines, -0 lines	2 comments	Download
M	utils/tests/pub/oauth2_test.dart	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	utils/tests/pub/pub_lish_test.dart	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	utils/tests/pub/validator_test.dart	View	4 chunks	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

I think this be a warning, but I'm guessing you disagree. Either way, LGTM. https://codereview.chromium.org/11474047/diff/1/utils/pub/validator/license.dart ...

8 years ago (2012-12-08 03:21:50 UTC) #2

nweiz

8 years ago (2012-12-08 03:24:27 UTC) #3

https://codereview.chromium.org/11474047/diff/1/utils/pub/validator/license.dart
File utils/pub/validator/license.dart (right):

https://codereview.chromium.org/11474047/diff/1/utils/pub/validator/license.d...
utils/pub/validator/license.dart:18: return
listDir(entrypoint.root.dir).transform((files) {
On 2012/12/08 03:21:50, Bob Nystrom wrote:
> Does this do a recursive list?

No, we don't want it picking up files in third_party or whatever.

Expand Messages | Collapse Messages