Issue 11474046: Make sure to drain stderr in tests so that spawned process doesn't hang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11474046: Make sure to drain stderr in tests so that spawned process doesn't hang. (Closed)

Created:
8 years ago by Bob Nystrom

Modified:
8 years ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make sure to drain stderr in tests so that spawned process doesn't hang. Committed: https://code.google.com/p/dart/source/detail?r=15874

Patch Set 2 : Add bug. #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -29 lines)			Patch
M	utils/pub/io.dart	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	utils/pub/log.dart	View		5 chunks	+36 lines, -26 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View		3 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/11474046/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://codereview.chromium.org/11474046/diff/1/utils/pub/io.dart#newcode610 utils/pub/io.dart:610: /// their output streams have been drained. Mention ...

8 years ago (2012-12-08 02:06:46 UTC) #2

Bob Nystrom

8 years ago (2012-12-08 02:37:05 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11474046/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/11474046/diff/1/utils/pub/io.dart#newcode610
utils/pub/io.dart:610: /// their output streams have been drained.
On 2012/12/08 02:06:46, nweiz wrote:
> Mention the issue number here.

Done.

https://codereview.chromium.org/11474046/diff/1/utils/pub/io.dart#newcode615
utils/pub/io.dart:615: // that explicitly.
On 2012/12/08 02:06:46, nweiz wrote:
> This comment is no longer relevant.

Done.

Expand Messages | Collapse Messages

Issue 11474046: Make sure to drain stderr in tests so that spawned process doesn't hang. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add bug. #

Messages