Issue 11473018: Improve streaming UTF-8 decoder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11473018: Improve streaming UTF-8 decoder (Closed)

Created:
8 years ago by Søren Gjesse

Modified:
7 years, 11 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Improve streaming UTF-8 decoder Decode 5 and 6 byte UTF-8. Convert code points not supported by Dart into replacement character. Better error checking. Added test of some corner cases. R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16573

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -2 lines)			Patch
	M	sdk/lib/io/string_stream.dart	View		3 chunks	+30 lines, -2 lines	1 comment	Download
	A	tests/standalone/io/string_decoder_test.dart	View		1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

8 years ago (2012-12-07 11:43:21 UTC) #2

LGTM

https://codereview.chromium.org/11473018/diff/1/sdk/lib/io/string_stream.dart
File sdk/lib/io/string_stream.dart (right):

https://codereview.chromium.org/11473018/diff/1/sdk/lib/io/string_stream.dart...
sdk/lib/io/string_stream.dart:233: print(value.toRadixString(16));
hovsa. ;-)

Expand Messages | Collapse Messages