Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1147233002: Change the way we look up packages for tests. (Closed)

Created:
5 years, 7 months ago by nweiz
Modified:
5 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub_test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change the way we look up packages for tests. Instead of looking in the repo's third party deps, this uses the packages installed for pub in the package cache. Archived versions of barback and source_maps are included via Git submodules. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/3bcc99ab1b466e4455fe9addaeb5ad6b556ad690

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -38 lines) Patch
A .gitmodules View 1 chunk +12 lines, -0 lines 0 comments Download
M README.md View 1 3 chunks +19 lines, -25 lines 0 comments Download
M pubspec.yaml View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/test_pub.dart View 5 chunks +25 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nweiz
5 years, 7 months ago (2015-05-21 00:43:53 UTC) #1
Bob Nystrom
https://codereview.chromium.org/1147233002/diff/1/.gitmodules File .gitmodules (right): https://codereview.chromium.org/1147233002/diff/1/.gitmodules#newcode12 .gitmodules:12: url = git://github.com/dart-lang/source_maps Where do the actual commits get ...
5 years, 7 months ago (2015-05-21 19:46:40 UTC) #2
nweiz
Also updated the README. https://codereview.chromium.org/1147233002/diff/1/.gitmodules File .gitmodules (right): https://codereview.chromium.org/1147233002/diff/1/.gitmodules#newcode12 .gitmodules:12: url = git://github.com/dart-lang/source_maps On 2015/05/21 ...
5 years, 7 months ago (2015-05-21 20:11:31 UTC) #3
nweiz
Code review changes
5 years, 7 months ago (2015-05-21 20:11:53 UTC) #4
Bob Nystrom
On 2015/05/21 20:11:31, nweiz wrote: > Also updated the README. Did you upload the patch? ...
5 years, 7 months ago (2015-05-21 20:12:14 UTC) #5
Bob Nystrom
LGTM!
5 years, 7 months ago (2015-05-21 20:16:41 UTC) #6
nweiz
5 years, 7 months ago (2015-05-21 20:31:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3bcc99ab1b466e4455fe9addaeb5ad6b556ad690 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698