Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1147213008: suggest keywords in if expression (Closed)

Created:
5 years, 6 months ago by danrubel
Modified:
5 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_contributor_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 6 months ago (2015-06-06 15:44:01 UTC) #2
scheglov
LGTM
5 years, 6 months ago (2015-06-06 16:42:28 UTC) #3
danrubel
5 years, 6 months ago (2015-06-12 07:50:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ce311218e91730ebb26f4533d852bda03a807684 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698