Issue 11472033: Fix "src" detection in the pub lish validator on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11472033: Fix "src" detection in the pub lish validator on Windows. (Closed)

Created:
8 years ago by nweiz

Modified:
8 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix "src" detection in the pub lish validator on Windows. Committed: https://code.google.com/p/dart/source/detail?r=15866

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	utils/pub/command_lish.dart	View		1 chunk	+2 lines, -0 lines	2 comments	Download
	M	utils/pub/validator/name.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM https://codereview.chromium.org/11472033/diff/1/utils/pub/command_lish.dart File utils/pub/command_lish.dart (right): https://codereview.chromium.org/11472033/diff/1/utils/pub/command_lish.dart#newcode146 utils/pub/command_lish.dart:146: // itself is in a directory named "packages". ...

8 years ago (2012-12-07 21:28:39 UTC) #2

nweiz

8 years ago (2012-12-07 21:33:31 UTC) #3

https://codereview.chromium.org/11472033/diff/1/utils/pub/command_lish.dart
File utils/pub/command_lish.dart (right):

https://codereview.chromium.org/11472033/diff/1/utils/pub/command_lish.dart#n...
utils/pub/command_lish.dart:146: // itself is in a directory named "packages".
On 2012/12/07 21:28:39, Bob Nystrom wrote:
> File a bug for this?

Done.

Expand Messages | Collapse Messages