Issue 11472032: Reapply change to use system code page on Windows to fix Pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11472032: Reapply change to use system code page on Windows to fix Pub. (Closed)

Created:
8 years ago by Mads Ager (google)

Modified:
8 years ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply change to use system code page on Windows to fix Pub. This time with correct null termination of the char* that we convert. R=sgjesse@google.com BUG=dartbug.com/7180 Committed: https://code.google.com/p/dart/source/detail?r=15860

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -5 lines)			Patch
M	runtime/bin/io_natives.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/bin/process.cc	View	2 chunks	+37 lines, -0 lines	1 comment	Download
M	runtime/bin/process_patch.dart	View	2 chunks	+14 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/io_patch.dart	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	sdk/lib/io/input_stream.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sdk/lib/io/process.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/io/string_stream.dart	View	4 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

8 years ago (2012-12-07 20:14:17 UTC) #2

TBR

https://codereview.chromium.org/11472032/diff/1/runtime/bin/process.cc
File runtime/bin/process.cc (right):

https://codereview.chromium.org/11472032/diff/1/runtime/bin/process.cc#newcod...
runtime/bin/process.cc:189: uint8_t* buffer = new uint8_t[bytes_length + 1];
This and the '\0' assignment below are the only changes.

Expand Messages | Collapse Messages