Issue 114713002: VM: Support calling through getters in InstanceMirror.delegate. Implement without accessing private…

Issue 114713002: VM: Support calling through getters in InstanceMirror.delegate. Implement without accessing private… (Closed)

Created:
7 years ago by rmacnak

Modified:
7 years ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

VM: Support calling through getters in InstanceMirror.delegate. Implement without accessing private members of dart:core. Fix language test expecting wrong return value. BUG=http://dartbug.com/15138 R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=31140

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove dead static var #

Patch Set 3 : " #

Patch Set 4 : sync #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -87 lines)			Patch
M	runtime/lib/corelib_sources.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	runtime/lib/invocation_mirror.cc	View		1 chunk	+0 lines, -56 lines	0 comments	Download
M	runtime/lib/invocation_mirror_patch.dart	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	1	2 chunks	+16 lines, -13 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/invocation_mirror2_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/lib/mirrors/delegate_call_through_getter_test.dart	View		1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. Nice simplification! https://codereview.chromium.org/114713002/diff/1/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/114713002/diff/1/runtime/lib/mirrors_impl.dart#newcode266 runtime/lib/mirrors_impl.dart:266: static Function _invokeOnClosure; With your cleanup ...

7 years ago (2013-12-13 12:26:24 UTC) #2

Florian Schneider

On 2013/12/13 12:26:24, Florian Schneider wrote: > LGTM. Nice simplification! > > https://codereview.chromium.org/114713002/diff/1/runtime/lib/mirrors_impl.dart > File ...

7 years ago (2013-12-13 13:15:58 UTC) #3

rmacnak

https://codereview.chromium.org/114713002/diff/1/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/114713002/diff/1/runtime/lib/mirrors_impl.dart#newcode266 runtime/lib/mirrors_impl.dart:266: static Function _invokeOnClosure; On 2013/12/13 12:26:24, Florian Schneider wrote: ...

7 years ago (2013-12-13 18:16:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r31140 (presubmit successful).

Expand Messages | Collapse Messages