Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 11470025: Adding interfaces for various types of InputElement (Closed)

Created:
8 years ago by blois
Modified:
8 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding interfaces for various types of InputElement Currently there's a set of them which only work in DRT, but I've added all of them. Was considering adding supported checks, but would prefer to defer till when we standardize our platform support story. BUG=1684 Committed: https://code.google.com/p/dart/source/detail?r=15988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1652 lines, -5 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +487 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +485 lines, -3 lines 0 comments Download
A sdk/lib/html/templates/html/impl/impl_HTMLInputElement.darttemplate View 1 chunk +498 lines, -0 lines 0 comments Download
M tests/html/html.status View 5 chunks +28 lines, -0 lines 0 comments Download
A tests/html/input_element_test.dart View 1 chunk +154 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
8 years ago (2012-12-07 23:52:29 UTC) #1
Jennifer Messerly
lgtm!
8 years ago (2012-12-10 19:27:53 UTC) #2
justinfagnani
8 years ago (2012-12-11 01:54:16 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698