Issue 11470023: Add in basic logging system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11470023: Add in basic logging system. (Closed)

Created:
8 years ago by Bob Nystrom

Modified:
8 years ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add in basic logging system. Committed: https://code.google.com/p/dart/source/detail?r=15870

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+297 lines, -35 lines)			Patch
M	utils/pub/command_help.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
A	utils/pub/log.dart	View	1 chunk	+217 lines, -0 lines	2 comments	Download
M	utils/pub/pub.dart	View	10 chunks	+65 lines, -28 lines	0 comments	Download
M	utils/tests/pub/pub_test.dart	View	1 chunk	+10 lines, -3 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

The next piece. This adds the logging library and wires it into the pub app, ...

8 years ago (2012-12-07 21:42:26 UTC) #1

nweiz

lgtm https://codereview.chromium.org/11470023/diff/1/utils/pub/log.dart File utils/pub/log.dart (right): https://codereview.chromium.org/11470023/diff/1/utils/pub/log.dart#newcode129 utils/pub/log.dart:129: buffer.add('[${output.length - 1000}] more lines of output truncated...]'); ...

8 years ago (2012-12-07 21:47:06 UTC) #2

Bob Nystrom

8 years ago (2012-12-07 22:19:55 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11470023/diff/1/utils/pub/log.dart
File utils/pub/log.dart (right):

https://codereview.chromium.org/11470023/diff/1/utils/pub/log.dart#newcode129
utils/pub/log.dart:129: buffer.add('[${output.length - 1000}] more lines of
output truncated...]');
On 2012/12/07 21:47:06, nweiz wrote:
> Long line.

Done.

Expand Messages | Collapse Messages